-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Packages #50
Upgrade Packages #50
Conversation
@@ -82,39 +81,11 @@ We plan to utilize API versioning to make automatic updates safe for consumer co | |||
|
|||
To use the Block Data API after activation, skip to [Usage](#usage). | |||
|
|||
### Install via `git subtree` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ingeniumed Are we deleting this section? I think it may still useful for VIP customers uninterested in the automatic integration mode, and non-VIP customers that want to add the plugin to existing repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed it, and will keep this change.
### Install via ZIP file | ||
|
||
The latest version of the plugin can be downloaded from the [repository's Releases page][repo-releases]. Unzip the downloaded plugin and add it to the `plugins/` directory of your site's GitHub repository. | ||
|
||
### Plugin activation | ||
#### Plugin activation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd keep this at a level 3 header, as it makes "plugin activation" a child of "Install via ZIP file" structurally and in the table of contents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed it, and will keep this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Left a couple of small comments on the README, let me know if you disagree with either. Thanks!
Description
This PR has been made in order to upgrade the packages in the composer.json, as well as fix any problems that arise due to it. I've also updated the README.md instructions's installation section to match what was done in the VIP-Decoupled-Bundle.
It's going into a planned release branch as this will be part of the WP-GraphQL release.
Steps to Test